Skip to content

Fix logic for orbit direction time offset #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2025
Merged

Fix logic for orbit direction time offset #360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32f99a7
Fix logic for orbit direction time offset
yuanjianz May 20, 2025
aeb9e8e
Fix deprecated warning for xarray drop
yuanjianz May 22, 2025
c2b90b6
Update CHANGELOG.md
yuanjianz May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
All notable changes to GCPy will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
## [Unreleased] - TBD
### Fixed
- Fix the logic of ravel_1D that creates orbit file for 1D GCHP diagnostic

## [1.6.1] - 2025-03-24
### Added
Expand Down
10 changes: 5 additions & 5 deletions gcpy/raveller_1D.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ def create_track_func(args):
#(ds['latitude'] / 180) * args.vertical_scan_time) % 24
# vary overpass time with latitude
overpass_offset = ds['latitude'] / 90 * 24 / args.orbits_per_day / 4 * 60
if args.direction == 'ascending':
# overpass delayed at high northern latitudes if ascending
if args.direction == 'descending':
# overpass advanced at high northern latitudes if descending
overpass_offset = -overpass_offset

longitude = ds.longitude.values
Expand All @@ -57,7 +57,7 @@ def create_track_func(args):
ds = ds.sortby('time')

ds = ds.reset_index('track')
ds = ds.assign_coords({'track': ds.time}).drop(
ds = ds.assign_coords({'track': ds.time}).drop_vars(
'time').rename({'track': 'time'})

ds['longitude'].attrs['long_name'] = 'longitude'
Expand All @@ -67,7 +67,7 @@ def create_track_func(args):
ds['latitude'].attrs['long_name'] = 'latitude'
ds['latitude'].attrs['units'] = 'degrees_north'

ds2 = ds.drop(['nf', 'Ydim', 'Xdim'])
ds2 = ds.drop_vars(['nf', 'Ydim', 'Xdim'])
ds2['nf'] = xr.DataArray(ds.nf.values, dims=['time'])
ds2['Ydim'] = xr.DataArray(ds.Ydim.values, dims=['time'])
ds2['Xdim'] = xr.DataArray(ds.Xdim.values, dims=['time'])
Expand Down Expand Up @@ -126,7 +126,7 @@ def has_converged(absdiff, curr_min, n=10):

# Create a multiindex for nf,Ydim,Xdim
track_mi = pd.MultiIndex.from_arrays([track.nf.values, track.Ydim.values, track.Xdim.values], names=['nf', 'Ydim', 'Xdim'])
track = track.drop(['nf', 'Ydim', 'Xdim', 'latitude', 'longitude'])
track = track.drop_vars(['nf', 'Ydim', 'Xdim', 'latitude', 'longitude'])

# Merge datasets
tracked_output = tracked_output
Expand Down