-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Description
We've had several complaints that the WebView2Loader.dll binary that ships inside of GCM causes signing problems. First for getting Git for Windows submitted to the Microsoft Store (git-for-windows/git#1146 (comment)), and more recently problems with GitHub Desktop.
The WebView2Loader.dll comes in from our dependency on MSAL.NET's Microsoft.Identity.Client.Desktop package. We need that package on Windows to bring in support for WAM when targeting .NET Framework (as apposed to netX-windows*).
The annoying thing is that we don't even use WebView2 because of various problems with it. We tried to move to .NET 5 on Window in the past and this resulted in an unacceptable bloat in binary size. When we turned all the optimisations/linking up to the highest level we only managed to reduce binary size a small amount, but broke things like UI.
We may have to drop WAM entirely. cc: @bgavrilMS