feat: allow direct pdf archives #942
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #942 +/- ##
==========================================
+ Coverage 34.74% 35.59% +0.85%
==========================================
Files 61 65 +4
Lines 5322 5557 +235
==========================================
+ Hits 1849 1978 +129
- Misses 3249 3349 +100
- Partials 224 230 +6 ☔ View full report in Codecov by Sentry. |
…feat/pdf-archiver
- Resolved conflicts in go.mod/go.sum (used newer dependency versions) - Resolved conflicts in database files (used new query builder patterns) - Resolved conflicts in internal/cmd/add.go (used new dependency interface) - Resolved conflicts in internal/core/ebook.go (used new ProcessRequest pattern) - Resolved conflicts in internal/domains/archiver.go (simplified archiver logic) - Resolved conflicts in internal/domains/bookmarks_test.go (used new dependency interface) - Removed deleted route files (moved to new handler structure) - Used master version of bookmark model and handler-api Note: Some compilation issues remain due to architectural differences between branches. These will be addressed in follow-up commits.
- Added missing Archiver and ArchivePath fields to BookmarkDTO - Fixed database struct initialization (NewDBBase calls) - Updated domain dependency access patterns (deps.Domains() calls) - Fixed ProcessRequest usage in ebook generation - Simplified webserver archiver calls (removed non-existent ProcessBookmarkArchive) - Fixed archiver package dependency access patterns - Added missing methods to ArchiverDomain interface and implementation - Updated all dependency access to use new function-based interface The feat/pdf-archiver branch now compiles successfully and is ready for testing.
- Convert EbookProcessRequest to ProcessRequest in ebook_test.go - Fix DownloadBookmarkArchive -> GenerateBookmarkArchive method call in bookmark_test.go - All go vet checks now pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to provide PDF archives for bookmarks by directly downloading the file.
Notable changes
ArchiverDomainArchiverDomaininitializes a list of archivers that try to match the content type, if it does, that archiver is used. If an error is raised, the next archiver is used and so on.PDFArchiver: Just downloads the file.WARCArchiveras a "catch all" (current default)bookmark.archiver(warc/pdf) andarchive_path.archive_path != ""Pending
archive_pathfor existing bookmarks: iterate over the bookmarks, check if the archive exists and set the path and thearchivertowarc.Closes #929