Skip to content

Monorepo style suggested changes #590

@Capstan

Description

@Capstan

Internally to Google, clshepherd / clrobot suggest changes to apply best practices. It made the following suggestions:

Fix 2 ErrorProneStyle findings:

  • Constructors and methods with the same name should appear sequentially with no other code in between. Please re-order or re-name methods.
  • This catch block catches an exception and re-throws another, but swallows the caught exception rather than setting it as a cause. This can make debugging harder.

I'm not sure these are all available via the public errorprone module, but perhaps some would get caught upstream if it were installed per https://errorprone.info/docs/installation#maven.

Metadata

Metadata

Assignees

Labels

api: datastoreIssues related to the googleapis/java-datastore API.type: cleanupAn internal cleanup or hygiene concern.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions