Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: googleapis/nodejs-datastore
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v8.2.2
Choose a base ref
...
head repository: googleapis/nodejs-datastore
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v8.3.0
Choose a head ref
  • 17 commits
  • 13 files changed
  • 5 contributors

Commits on Oct 18, 2023

  1. chore(deps): update dependency @types/is to v0.0.24 (#1175)

    [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
    
    This PR contains the following updates:
    
    | Package | Change | Age | Adoption | Passing | Confidence |
    |---|---|---|---|---|---|
    | [@types/is](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/is) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped)) | [`0.0.23` -> `0.0.24`](https://renovatebot.com/diffs/npm/@types%2fis/0.0.23/0.0.24) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@types%2fis/0.0.24?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@types%2fis/0.0.24?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@types%2fis/0.0.23/0.0.24?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@types%2fis/0.0.23/0.0.24?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
    
    ---
    
    ### Configuration
    
    📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined).
    
    🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
    
    ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
    
    🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
    
    ---
    
     - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
    
    ---
    
    This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/googleapis/nodejs-datastore).
    <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOS4yIiwidXBkYXRlZEluVmVyIjoiMzcuMTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
    renovate-bot authored Oct 18, 2023
    Configuration menu
    Copy the full SHA
    15ed1dd View commit details
    Browse the repository at this point in the history
  2. test: Change the filter samples to use entity filters (#1172)

    * Change the filter samples to use entity filters
    
    Property filters should be used in most places instead of the legacy filter functionality.
    
    * Get rid of the source import
    
    This auto-import breaks the samples tests
    
    * run linter
    
    * Empty-Commit
    
    * 🦉 Updates from OwlBot post-processor
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    ---------
    
    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    danieljbruce and gcf-owl-bot[bot] authored Oct 18, 2023
    Configuration menu
    Copy the full SHA
    69fc050 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. Configuration menu
    Copy the full SHA
    52adb5e View commit details
    Browse the repository at this point in the history
  2. fix: Change tests to use new filter and use gax warn for warning just…

    … once (#1185)
    
    * trim operator
    
    In the legacy version of filter we trim the operator. We should do this here too.
    
    * In test cases, replace various filter calls
    
    Always pass entity filters into the filter function in tests to reflect new behavior.
    
    * accept string too
    
    A string is needed as an input parameter because we might trim it to get an operator.
    
    * Use .filter the old way
    
    Revert changes on the .filter method
    
    * Change docs to use new filter
    
    The new property filter should be used and this should be reflected in the doc comments.
    
    * Use new Property filter
    
    In entity.ts, use the new property filter constructor.
    
    * Revert changes to operator
    
    The changes cause compiler errors. Do not trim the operator for now.
    
    * Move test up and add change
    
    Add change to issue warning just once. Use google-gax so that the warning is issued just once.
    
    * Revert "Change docs to use new filter"
    
    This reverts commit c290481.
    
    * run linter
    
    * Add a test to ensure just one warning
    
    A test to make sure the warning is emitted just once might provide proper coverage.
    danieljbruce authored Oct 23, 2023
    Configuration menu
    Copy the full SHA
    532711b View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. chore(deps): update actions/setup-node action to v4 (#1186)

    * chore(deps): update actions/setup-node action to v4
    
    * 🦉 Updates from OwlBot post-processor
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    ---------
    
    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    renovate-bot and gcf-owl-bot[bot] authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    07f76a9 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. chore(deps): update actions/setup-node action to v4 (#1187)

    * chore(deps): update actions/setup-node action to v4
    
    * 🦉 Updates from OwlBot post-processor
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    ---------
    
    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    renovate-bot and gcf-owl-bot[bot] authored Oct 25, 2023
    Configuration menu
    Copy the full SHA
    b1f2da9 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. chore(deps): update actions/setup-node action to v4 (#1189)

    * chore(deps): update actions/setup-node action to v4
    
    * 🦉 Updates from OwlBot post-processor
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    ---------
    
    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    renovate-bot and gcf-owl-bot[bot] authored Oct 26, 2023
    Configuration menu
    Copy the full SHA
    73c7001 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. chore(deps): update actions/setup-node action to v4 (#1190)

    * chore(deps): update actions/setup-node action to v4
    
    * 🦉 Updates from OwlBot post-processor
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    ---------
    
    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    renovate-bot and gcf-owl-bot[bot] authored Oct 27, 2023
    Configuration menu
    Copy the full SHA
    3b2712b View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. Configuration menu
    Copy the full SHA
    e56a475 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. chore(deps): update dependency @types/is to v0.0.25 (#1198)

    [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
    
    This PR contains the following updates:
    
    | Package | Change | Age | Adoption | Passing | Confidence |
    |---|---|---|---|---|---|
    | [@types/is](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/is) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped)) | [`0.0.24` -> `0.0.25`](https://renovatebot.com/diffs/npm/@types%2fis/0.0.24/0.0.25) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@types%2fis/0.0.25?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@types%2fis/0.0.25?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@types%2fis/0.0.24/0.0.25?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@types%2fis/0.0.24/0.0.25?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
    
    ---
    
    ### Configuration
    
    📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined).
    
    🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
    
    ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
    
    🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
    
    ---
    
     - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
    
    ---
    
    This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/googleapis/nodejs-datastore).
    <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40Ni4wIiwidXBkYXRlZEluVmVyIjoiMzcuNDYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
    renovate-bot authored Nov 7, 2023
    Configuration menu
    Copy the full SHA
    5a896bd View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. chore: update cloud-rad version to ^0.4.0 (#1199)

    Source-Link: googleapis/synthtool@1063ef3
    Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:e92044720ab3cb6984a70b0c6001081204375959ba3599ef6c42dd99a7783a67
    
    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    gcf-owl-bot[bot] and gcf-owl-bot[bot] authored Nov 13, 2023
    Configuration menu
    Copy the full SHA
    b86c79b View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. build: update Node.js generator to compile protos (#1200)

    * build: update Node.js generator to compile protos
    
    PiperOrigin-RevId: 582493526
    
    Source-Link: googleapis/googleapis@7c4e4b5
    
    Source-Link: googleapis/googleapis-gen@368cfb6
    Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzY4Y2ZiNjUxMDE2ZDZhOTNjYTZlNDg4Y2JjMzRlMmQxZDlkMjEyYyJ9
    
    * 🦉 Updates from OwlBot post-processor
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    ---------
    
    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    gcf-owl-bot[bot] and gcf-owl-bot[bot] authored Nov 20, 2023
    Configuration menu
    Copy the full SHA
    75949b5 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. chore(deps): update actions/setup-node action to v4 (#1192)

    * chore(deps): update actions/setup-node action to v4
    
    * 🦉 Updates from OwlBot post-processor
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    ---------
    
    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    Co-authored-by: danieljbruce <danieljbruce@users.noreply.github.com>
    3 people authored Dec 5, 2023
    Configuration menu
    Copy the full SHA
    3e39c24 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. chore(deps): update actions/setup-node action to v4 (#1208)

    * chore(deps): update actions/setup-node action to v4
    
    * 🦉 Updates from OwlBot post-processor
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    ---------
    
    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    renovate-bot and gcf-owl-bot[bot] authored Dec 6, 2023
    Configuration menu
    Copy the full SHA
    e557eaf View commit details
    Browse the repository at this point in the history
  2. chore(deps): update actions/setup-node action to v4 (#1209)

    * chore(deps): update actions/setup-node action to v4
    
    * 🦉 Updates from OwlBot post-processor
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    ---------
    
    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    renovate-bot and gcf-owl-bot[bot] authored Dec 6, 2023
    Configuration menu
    Copy the full SHA
    f883772 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. feat: Allow the user to set fallback to rest (#1203)

    * Allow the user to set fallback to rest
    
    This provides a workaround for the connection issue.
    
    * Putting together a test that mocks out gapic
    
    Need to mock out Gapic and compare constructors
    
    * This harness works properly
    
    The harness mocks out the constructor and calls reach the constructor as well as the get function. So now we can see what values get passed into the constructor and get function.
    
    * Add client testing module
    
    Add a working test that makes sure the rest parameter gets passed down to the gapic layer.
    
    * Regroup the code so it is better arranged
    
    Proper describe blocks make it easier for the code to be arranged so that with and without rest tests can be incorporated into the code.
    
    * Remove the datastore mock
    
    Remove the datastore mock. It is not necessary.
    
    * Add comments for test helper functions. Add tests for the non rest case.
    
    * Clean up source code change
    
    Make a programmatic link to the data type so that the intent is clearer.
    
    * Add parameterized test
    
    Parameterized tests will allow us to delete half the tests. A new type is created for the test parameters.
    
    * Document the class for mocking datastore client
    
    Explain the purpose of the class. This will make it useful for testing.
    
    * Remove only
    
    * Remove fallback params type
    
    This type is only used once so inline it.
    
    * Remove changes to system tests
    
    Changes to system tests are not necessary. Remove them.
    
    * Add header
    
    * Check for client existence
    
    assert resolves to falsy in tests. See if this solves the issue.
    
    * Change it back
    
    Add console logs and assert checks back in.
    
    * Add more debugger logs
    
    * Add project load logs
    
    * console error
    
    * Add comment for mocking out project id
    
    This should allow the unit tests to pass in the continuous integration environment.
    
    * linting fix
    
    * Correct title of describe block
    
    The title of the describe block should match the file. Remove console logs too.
    
    * Change rest parameter in test to fallback
    
    This parameter more specifically describes the change.
    
    * Create a simple system test for using rest
    
    This system test should show how the rest parameter is being used.
    
    * Should check to see if entity is undefined
    
    This allows the test to pass with a simple assertion check.
    
    * Specify fallback type instead of string | undefin
    
    Fallback type is more specific . Use it instead.
    danieljbruce authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    8a1fa54 View commit details
    Browse the repository at this point in the history
  2. chore(main): release 8.3.0 (#1184)

    Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
    release-please[bot] authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    eb4295c View commit details
    Browse the repository at this point in the history
Loading