feat(lessons): auto-discover lessons from plugins (#944)

TimeToBuildBob · ErikBjare · web-flow · commit ab531ad20127 · 2025-12-10T13:18:45.000+01:00
* feat(lessons): auto-discover lessons from plugins

When plugins are configured via [plugins].paths, automatically search
each plugin's lessons/ directory for lesson files.

This enables plugins to ship with their own lessons that get included
automatically when the plugin is loaded.

* fix(lessons): handle src/ layout for plugin lesson discovery

When plugins use the standard Python src/ layout, plugin.path points to
the module inside src/ (e.g., /project/src/module/), not the project root.
This caused lessons/ directories at the project root to not be found.

Fix:
1. First check plugin.path/lessons (flat layout)
2. If not found, walk up to find project root (where pyproject.toml is)
3. Check for lessons/ at project root for src/ layout plugins
4. Use is_dir() instead of exists() per code review suggestion

Fixes issue identified by Greptile: plugins with src/ layout structure
(pyproject.toml + src/ directory) would not have their lessons discovered.

---------

Co-authored-by: Erik Bjäreholt &lt;erik@bjareho.lt&gt;
diff --git a/gptme/lessons/index.py b/gptme/lessons/index.py
@@ -155,6 +155,36 @@ def _default_dirs() -> list[Path]:
                 if lesson_dir.exists():
                     dirs.append(lesson_dir)
 
+        # Plugin lesson directories (auto-discovered from [plugins].paths)
+        if config.project and config.project.plugins.paths:
+            from ..plugins import discover_plugins
+
+            plugin_paths = [
+                Path(p).expanduser().resolve() for p in config.project.plugins.paths
+            ]
+            plugins = discover_plugins(plugin_paths)
+            for plugin in plugins:
+                # Check for lessons/ directory in plugin
+                # For flat layout: lessons/ is directly in plugin.path
+                # For src/ layout: plugin.path is src/module/, so lessons/ is at project root
+                plugin_lessons_dir = plugin.path / "lessons"
+                if plugin_lessons_dir.is_dir():
+                    dirs.append(plugin_lessons_dir)
+                    logger.debug(
+                        f"Found plugin lessons: {plugin.name} -> {plugin_lessons_dir}"
+                    )
+                else:
+                    # Check for src/ layout: walk up to find project root
+                    # plugin.path might be /project/src/module/, lessons at /project/lessons/
+                    project_root = plugin.path.parent.parent
+                    if (project_root / "pyproject.toml").exists():
+                        project_lessons_dir = project_root / "lessons"
+                        if project_lessons_dir.is_dir():
+                            dirs.append(project_lessons_dir)
+                            logger.debug(
+                                f"Found plugin lessons (src layout): {plugin.name} -> {project_lessons_dir}"
+                            )
+
         return dirs
 
     def _index_lessons(self) -> None:
