Skip to content

Undefined function in binary.js inside the published npm package  #28

@thomaschampagne

Description

@thomaschampagne

Hey @jimmykane,

I'm looking to understand why every cycling dynamics stats like avg_left_power_phase, avg_left_power_phase_peak are returning NaN values inside this library (file used: 7386755164.zip).

1 - I noticed that in the npm distributed package (v1.9.0) the following file node_modules\fit-file-parser\dist\binary.js has an error. Indeed inside function readData the following line:

return dataView.getUnt8(0, fDef.littleEndian);

Should be

return dataView.getUint8(0, fDef.littleEndian);

getUnt8 function doesn't exists, the getUint8 yes !

2 - Aside this, the readData (dist folder) from repository is not the same than the npm package. Why? I was unable to find tag 1.9.0 on this repository.

Thanks for your help !

Thomas

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions