-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Closed
Labels
help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Description
we have an automation that updates "cni-plugins-version" Example This PR: #20749
however I noticed it does NOT update a few places such as
- Github Action Yamls
- https://github.com/medyagh/minikube/blob/88e5a27313962b14bf811625d6ed9257c3bcc38e/.github/workflows/pr.yml#L568
- https://github.com/medyagh/minikube/blob/88e5a27313962b14bf811625d6ed9257c3bcc38e/.github/workflows/master.yml#L570
the automation script lives here
https://github.com/kubernetes/minikube/blob/master/hack/update/cni_plugins_version/update_cni_plugins_version.go
Expected Result
so when the automation PR runs make update-cni-plugins-version it should updated those files above too
Metadata
Metadata
Assignees
Labels
help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.Must be staffed and worked on either currently, or very soon, ideally in time for the next release.