Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kaushiknsanji/StoreApp
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: udacity
Choose a base ref
...
head repository: kaushiknsanji/StoreApp
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: release_v1.0
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 17 commits
  • 45 files changed
  • 1 contributor

Commits on Nov 6, 2019

  1. refactor: View alignment corrections and optimizations

    @kaushiknsanji
    kaushiknsanji committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    92c56ab View commit details
    Browse the repository at this point in the history

  2. refactor: Add Base values for dimensions used in Landscape orientatio… 

    …n only
    @kaushiknsanji
    kaushiknsanji committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    fd9a813 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2019

  1. fix: Save Product Images to the database only when there is an update… 

    …/change
    @kaushiknsanji
    kaushiknsanji committed Nov 8, 2019
    Configuration menu
    Copy the full SHA
    d4b641e View commit details
    Browse the repository at this point in the history

  2. fix: Discard dialog for unsaved changes to be shown only when there i… 

    …s an update/change

Discard dialog was previously shown even when there was no change in the data. This fix compares the existing state with its updated state in order to show the Discard dialog, only when there is mismatch between the states, to allow the user to save the unsaved changes.
    @kaushiknsanji
    kaushiknsanji committed Nov 8, 2019
    Configuration menu
    Copy the full SHA
    b460473 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2019

  1. fix: Delete Product Images when the Product is deleted from the database 

    Previously, Product Images were deleted on the deletion of Product from SalesConfig and ProductConfig Screens only. This fix ensures Product Images are deleted on the deletion of Product from the List screens by executing the image deletion process on success of product deletion in the Repository implementation, instead of doing in the Presenter implementation of the respective SalesConfig and ProductConfig screens.
    @kaushiknsanji
    kaushiknsanji committed Nov 9, 2019
    Configuration menu
    Copy the full SHA
    0333f83 View commit details
    Browse the repository at this point in the history

  2. fix: Release Orientation lock when a Dialog is canceled on touch from… 

    … outside
    @kaushiknsanji
    kaushiknsanji committed Nov 9, 2019
    Configuration menu
    Copy the full SHA
    530d4e8 View commit details
    Browse the repository at this point in the history

  3. fix: Add vertical bias correction to "Add More" button in ProductConf… 

    …ig Screen
    @kaushiknsanji
    kaushiknsanji committed Nov 9, 2019
    Configuration menu
    Copy the full SHA
    2b7ea78 View commit details
    Browse the repository at this point in the history

  4. refactor: Log statements only for debuggable build types

    @kaushiknsanji
    kaushiknsanji committed Nov 9, 2019
    Configuration menu
    Copy the full SHA
    1f9526e View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2019

  1. fix: Pressing home/up button or back key on a New Config entry should… 

    … display the Discard dialog
    @kaushiknsanji
    kaushiknsanji committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    e0eef93 View commit details
    Browse the repository at this point in the history

  2. fix: Use the copy of the Product Attributes list to be able to detect… 

    … any changes later
    @kaushiknsanji
    kaushiknsanji committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    3508b06 View commit details
    Browse the repository at this point in the history

  3. fix: Null Pointer when a Contact is being recorded and another Contac… 

    …t is deleted at the same time
    @kaushiknsanji
    kaushiknsanji committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    8ace8ad View commit details
    Browse the repository at this point in the history

  4. refactor: Pass 0 as the required quantity to procure when no quantity… 

    … is provided
    @kaushiknsanji
    kaushiknsanji committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    a28a408 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2019

  1. fix: Improper Item decorations when a data item was added, updated or… 

    … removed from the list
    @kaushiknsanji
    kaushiknsanji committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    47df67d View commit details
    Browse the repository at this point in the history

  2. chore: Prepare for release

    @kaushiknsanji
    kaushiknsanji committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    e8f6bcd View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2019

  1. docs: Update README with the release details

    @kaushiknsanji
    kaushiknsanji committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    769881f View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2019

  1. chore: Comment corrections

    @kaushiknsanji
    kaushiknsanji committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    d22b6fd View commit details
    Browse the repository at this point in the history

  2. chore: README corrections

    @kaushiknsanji
    kaushiknsanji authored Nov 16, 2019
    Configuration menu
    Copy the full SHA
    0e9e41d View commit details
    Browse the repository at this point in the history
Loading