Skip to content

Do not use deprecated test containers in tests #45941

@mabartos

Description

@mabartos

Description

After the Quarkus 3.31.0 upgrade, the testcontainers were updated, but the deprecated classes are still used. It'd be good to use new ones.

[INFO] --- compiler:3.8.1:compile (default-compile) @ keycloak-junit5 ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 27 source files to /home/mabartos/Documents/RH/keycloak/quarkus/tests/junit5/target/classes
[WARNING] /home/mabartos/Documents/RH/keycloak/quarkus/tests/junit5/src/main/java/org/keycloak/it/junit5/extension/DatabaseContainer.java:[67,34] org.testcontainers.containers.MSSQLServerContainer in org.testcontainers.containers has been deprecated
[WARNING] /home/mabartos/Documents/RH/keycloak/quarkus/tests/junit5/src/main/java/org/keycloak/it/junit5/extension/DatabaseContainer.java:[74,34] org.testcontainers.containers.MSSQLServerContainer in org.testcontainers.containers has been deprecated
[WARNING] /home/mabartos/Documents/RH/keycloak/quarkus/tests/junit5/src/main/java/org/keycloak/it/junit5/extension/DatabaseContainer.java:[86,46] org.testcontainers.containers.MSSQLServerContainer in org.testcontainers.containers has been deprecated
[WARNING] /home/mabartos/Documents/RH/keycloak/quarkus/tests/junit5/src/main/java/org/keycloak/it/junit5/extension/DatabaseContainer.java:[107,51] org.testcontainers.containers.PostgreSQLContainer in org.testcontainers.containers has been deprecated
[WARNING] /home/mabartos/Documents/RH/keycloak/quarkus/tests/junit5/src/main/java/org/keycloak/it/junit5/extension/DatabaseContainer.java:[110,51] org.testcontainers.containers.MariaDBContainer in org.testcontainers.containers has been deprecated
[WARNING] /home/mabartos/Documents/RH/keycloak/quarkus/tests/junit5/src/main/java/org/keycloak/it/junit5/extension/DatabaseContainer.java:[113,51] org.testcontainers.containers.MySQLContainer in org.testcontainers.containers has been deprecated
[WARNING] /home/mabartos/Documents/RH/keycloak/quarkus/tests/junit5/src/main/java/org/keycloak/it/junit5/extension/DatabaseContainer.java:[116,51] org.testcontainers.containers.MSSQLServerContainer in org.testcontainers.containers has been deprecated
[WARNING] /home/mabartos/Documents/RH/keycloak/quarkus/tests/junit5/src/main/java/org/keycloak/it/junit5/extension/DatabaseContainer.java:[116,79] getLivenessCheckPortNumbers() in org.testcontainers.containers.MSSQLServerContainer implements getLivenessCheckPortNumbers() in org.testcontainers.containers.wait.strategy.WaitStrategyTarget
  return type requires unchecked conversion from java.util.Set to java.util.Set<java.lang.Integer>
[WARNING] /home/mabartos/Documents/RH/keycloak/quarkus/tests/junit5/src/main/java/org/keycloak/it/junit5/extension/DatabaseContainer.java:[116,79] getDependencies() in org.testcontainers.containers.GenericContainer implements getDependencies() in org.testcontainers.lifecycle.Startable
  return type requires unchecked conversion from java.util.Set to java.util.Set<org.testcontainers.lifecycle.Startable>
[WARNING] /home/mabartos/Documents/RH/keycloak/quarkus/tests/junit5/src/main/java/org/keycloak/it/junit5/extension/DatabaseContainer.java:[116,79] getPortBindings() in org.testcontainers.containers.GenericContainer implements getPortBindings() in org.testcontainers.containers.ContainerState
  return type requires unchecked conversion from java.util.List to java.util.List<java.lang.String>
[WARNING] /home/mabartos/Documents/RH/keycloak/quarkus/tests/junit5/src/main/java/org/keycloak/it/junit5/extension/DatabaseContainer.java:[116,79] getExposedPorts() in org.testcontainers.containers.GenericContainer implements getExposedPorts() in org.testcontainers.containers.ContainerState
  return type requires unchecked conversion from java.util.List to java.util.List<java.lang.Integer>
[WARNING] /home/mabartos/Documents/RH/keycloak/quarkus/tests/junit5/src/main/java/org/keycloak/it/junit5/extension/KeycloakDistributionDecorator.java:[143,24] unchecked cast

Value Proposition

  • Remove deprecated code

Goals

  • Use non-deprecated alternatives

Non-Goals

N/A

Discussion

No response

Notes

No response

Metadata

Metadata

Assignees

No fields configured for enhancement.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions