Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 5 commits
- 27 files changed
- 1 contributor
Commits on Sep 15, 2024
-
- feat: Deprecate the ability to define
static observedAttributesa……s a map of attribute names to attribute handlers for non-decorator users, and instead create a new `static observedAttributeHandlers` for that purpose. This keeps the type of `static observedAttributes` clean and aligned with the DOM spec, while the new `static observedAttributeHandlers` has the type definition for the library-specific feature. Plus this prevents type issues downstream because the `@element` decorator (callable as a function when not using decorators) coerces the object format into the standard array format, yet the object type will still sppear in subclasses despite that it is never an object in subclasses. - deprecation: `static observedAttributes = {}` is deprecated, and only the standard `static observedAttributes = []` should be used. The object format will be removed in a breaking version bump. - infra: Unrestrict the `typescript` version so we can keep it updated with other packages in the lume repo. -
Merge pull request #27 from lume/improve-observedAttributes-type
Deprecate the ability to define `static observedAttributes` as a map of attribute names to attribute handlers for non-decorator users, and instead create a new `static observedAttributeHandlers` for that purpose.
-
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.12.1...v0.12.3