-
Notifications
You must be signed in to change notification settings - Fork 246
Open
Description
Right now, we have jquery, angular and chosen-js as normal dependencies.
Especially for angular and jquery, this is a big issue when used with packers like webpack, because it might force the packer to include 2 versions of those huge libraries - the user-defined one in their package.json and ours. This will happen when the 2 versions are not semver compatible, which is quite easy to fall into.
I would say that we definitely want to move those two to a peerDependency.
For more on peer deps: https://nodejs.org/en/blog/npm/peer-dependencies/
Edit: As an aside, I'm not sure that we're using jQuery v3+ methods? Any reason for pinning to that instead of ^2.0? chosen-js itself supports ^1.4
leocaseiro