Skip to content

Make mouseup not close modal/popup, but require full click #12566

@TheMadSword

Description

@TheMadSword

When having a modal/pop-up open ('?' menu, but also notably when creating a new game), if you mouse-down in the modal but mouse-up outside the modal, then the modal close.

This is a bit annoying when creating a new game and scrolling to get the maximum amount of time (either initial, or want 180 sec per turn). Multiple scrolling instances when using a computer allow that and it is a nice little behaviour to have I believe (to be able to yolo your mouse in a direction without caring about a specific point; the new-game modal is also not so big).

Having that also makes it more forgiving and friendly for people with touchpad.

issue_modal_mouseup_compressed.mp4

I didn't create as a bug as it is arguably one, or arguably a nice-to-have.

EDIT : It seems to be not always be reproducable in a my Chrome.

Browser : M1 Mac, Chrome Version 111.0.5563.110 (Official Build) (arm64). It also seems I cannot reproduce on Firefox.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions