Skip to content

find_package(VERSION) is against the convention, as it uses SO version #95

@wrobelda

Description

@wrobelda

In #81 I rely on LIBOFX_LIBRARY_SONAME, introduced by #73. Namely, I do:

write_basic_package_version_file(${CMAKE_CURRENT_BINARY_DIR}/LibOFXConfigVersion.cmake
         VERSION ${LIBOFX_LIBRARY_VERSION}
         COMPATIBILITY SameMajorVersion
         )

, while #73 does :

set(LIBOFX_LIBRARY_VERSION ${LIBOFX_LIBRARY_SONAME}.0.2)

This makes sense from the perspective of versioning, where SameMajorVersion works as we intend, i.e. to indicate which versions are ABI-compatible.

However, this makes find_package(VERSION) calls unconventional, as one has to use ABI version here, as opposed to generic library release version.

So I suppose the solution is to actually to scrap the LIBOFX_LIBRARY_SONAME, replace it with LIBOFX_MAJOR_VERSION, effectively bump the SO version to 10 and leave it at that.

Side effect is that the SO version 10 would appear to be incompatible with the current 7, even though it is.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions