[POC] Allow clients to specify set TLS specifications per-request #6516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
6d0c923 to
bed240c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6516 +/- ##
============================================
- Coverage 74.46% 74.20% -0.27%
- Complexity 22234 23445 +1211
============================================
Files 1963 2110 +147
Lines 82437 87666 +5229
Branches 10764 11500 +736
============================================
+ Hits 61385 65050 +3665
- Misses 15918 17126 +1208
- Partials 5134 5490 +356 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ea6d7cf to
2f43df4
Compare
2f43df4 to
d4c99af
Compare
jrhee17
added a commit
that referenced
this pull request
Nov 28, 2025
…ertificateExtension (#6519) Motivation: This is the first of a series of PRs included by #6516. Currently, our mTLS tests are not realistic in that: - Certificate chains aren't verified - We set TLS configurations to not verify the peer, which means in reality there's no point in using mTLS. For this, I propose that a `SignedCertificate` is introduced. This is a certificate which is signed by another certificate (another `SignedCertificate` or `SelfSignedCertificate`). A JUnit `Extension` has also been introduced so users can easily test this behavior. In the process, I found that `SelfSingedCertificateNameType` has a typo, and isn't adding much value. This enum has been removed. Modifications: - Introduced `SignedCertificate`, `SignedCertificateExtension` - `SelfSignedCertificate`, `SelfSignedCertificateExtension` inherits the newly introduced constructs - Default behavior has been modified so that all generated certificates can act as a ca. - `SelfSingedCertificateNameType` has been removed Result: - Users can easily create a certificate chain for testing using `SignedCertificateExtension` <!-- Visit this URL to learn more about how to write a pull request description: https://armeria.dev/community/developer-guide#how-to-write-pull-request-description -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Explain why you're making this change and what problem you're trying to solve.
Modifications:
Result: