I've got a working PoC here: https://github.com/huuff/mockito/tree/predicate

This is an usage example:

#[test]
fn test_match_predicate() {
    let mut s = Server::new();
    s.mock("POST", "/")
        .match_body(|body: &str| body.contains("world"))
        .create();

    let (status, _, _) = request_with_body(s.host_with_port(), "POST /", "", "hello world");
    assert_eq!("HTTP/1.1 200 OK\r\n", status);
}

I honestly don't know why the closure input type can't be inferred.

I didn't need any proxy object (I guess concerns about exposing the request object may no longer apply to newer versions?), However, I think this may be a breaking change? Since some downstream crate might be matching on the Matcher enum (though it seems unlikely).

If this is a breaking change, it may be too much hassle for relatively little gain. Though this makes the matching system extensible, I think an approach that makes Matcher a trait instead would be much more powerful. Then any downstream crates could provide any Matchers and no further changes (especially breaking ones) would be necessary to the main crate to extend the matching system.

Uh oh!

Feature: Allow passing a closure to validate requests #95

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions