-
-
Notifications
You must be signed in to change notification settings - Fork 7k
fix: Resolver Game Server DNS before querying the IP #5970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
CommanderStorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this to be mergable, I would like to see a testcase (one dyndns, one not) or maybe just one which mocks part of this interaction
|
@CommanderStorm I reported on #5934, I'm having problems running tests with |
|
No I have not and CI also does not have the same problem. |
|
sorry for reopening, was a mistake, still working on the tests |
|
Wait, I think #5934 is about the Steam monitor, it is not related to the Gamedig one. Gamedig should be able to resolve hostname. I think this pr is fixing the wrong place. Am I missing anything? uptime-kuma/server/model/monitor.js Lines 660 to 667 in 0eebe86
|
❗ Important Announcements
Click here for more details:
🚫 Please Avoid Unnecessary Pinging of Maintainers
We kindly ask you to refrain from pinging maintainers unless absolutely necessary. Pings are for critical/urgent pull requests that require immediate attention.
📋 Overview
When monitoring a Steam game server with Kuma, I’m encountering an issue where using a domain name as the host doesn’t work properly. This is because Steam’s API uses the server’s public IP address, not the domain name, for health checks.
Context:
Expected behavior:
I would expect Kuma to resolve the domain name to its current IP and use that IP in the request.
🛠️ Type of change
📄 Checklist