Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MaskedTensor support to *_like API #128637

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nowtryz
Copy link
Contributor

@nowtryz nowtryz commented Jun 13, 2024

No description provided.

Copy link

pytorch-bot bot commented Jun 13, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128637

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3201935 with merge base 92151c8 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@soulitzer soulitzer self-requested a review June 14, 2024 01:30
@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 14, 2024
@nowtryz
Copy link
Contributor Author

nowtryz commented Aug 7, 2024

Hi @soulitzer or @cpuhrsch,

The PR is ready to merge.

cpuhrsch
cpuhrsch previously approved these changes Aug 8, 2024
@cpuhrsch
Copy link
Contributor

cpuhrsch commented Aug 8, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased feat/_like-api-maskedtensor onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout feat/_like-api-maskedtensor && git pull --rebase)

@cpuhrsch
Copy link
Contributor

cpuhrsch commented Aug 8, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 8, 2024
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@cpuhrsch cpuhrsch added release notes: sparse release notes category topic: new features topic category labels Aug 8, 2024
@cpuhrsch
Copy link
Contributor

cpuhrsch commented Aug 8, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@nowtryz nowtryz force-pushed the feat/_like-api-maskedtensor branch 2 times, most recently from 340cade to c4b46cd Compare August 15, 2024 21:01
@nowtryz
Copy link
Contributor Author

nowtryz commented Aug 15, 2024

I am not sure if I can use this command but as the change were approved:
@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 3 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@pytorch-bot pytorch-bot bot dismissed cpuhrsch’s stale review August 20, 2024 08:26

This PR was reopened (likely due to being reverted), so your approval was removed. Please request another review.

pytorchmergebot pushed a commit to mori360/pytorch that referenced this pull request Aug 20, 2024
@nowtryz
Copy link
Contributor Author

nowtryz commented Aug 22, 2024

Thank you @jeanschmidt,
Fixed the binding, can you merge again?

@nowtryz nowtryz requested a review from cpuhrsch August 23, 2024 15:14
cpuhrsch
cpuhrsch previously approved these changes Aug 28, 2024
@cpuhrsch
Copy link
Contributor

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@ZainRizvi
Copy link
Contributor

@pytorchbot revert -c nosignal -m "Actually, seems like it was this commit that introduced the failure: test_maskedtensor.py::TestOperatorsCUDA::test_like_empty_like_layout1_cuda_bool GH job link HUD commit link"

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@nowtryz your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Aug 29, 2024
This reverts commit b6e5171.

Reverted #128637 on behalf of https://github.com/ZainRizvi due to Actually, seems like it was this commit that introduced the failure: test_maskedtensor.py::TestOperatorsCUDA::test_like_empty_like_layout1_cuda_bool [GH job link](https://github.com/pytorch/pytorch/actions/runs/10604690725/job/29392898277) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/b6e51711a0ea6174806e75ab6e208d2d910b45f5) ([comment](#128637 (comment)))
@pytorch-bot pytorch-bot bot dismissed cpuhrsch’s stale review August 29, 2024 01:42

This PR was reopened (likely due to being reverted), so your approval was removed. Please request another review.

pytorch-bot bot pushed a commit that referenced this pull request Sep 13, 2024
pytorch-bot bot pushed a commit that referenced this pull request Sep 13, 2024
This reverts commit 8de56e2.

Reverted #128637 on behalf of https://github.com/jeanschmidt due to Introduced API linting errors ([comment](#128637 (comment)))
tolleybot pushed a commit to tolleybot/pytorch that referenced this pull request Sep 14, 2024
tolleybot pushed a commit to tolleybot/pytorch that referenced this pull request Sep 14, 2024
This reverts commit b6e5171.

Reverted pytorch#128637 on behalf of https://github.com/ZainRizvi due to Actually, seems like it was this commit that introduced the failure: test_maskedtensor.py::TestOperatorsCUDA::test_like_empty_like_layout1_cuda_bool [GH job link](https://github.com/pytorch/pytorch/actions/runs/10604690725/job/29392898277) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/b6e51711a0ea6174806e75ab6e208d2d910b45f5) ([comment](pytorch#128637 (comment)))
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
This reverts commit b6e5171.

Reverted pytorch#128637 on behalf of https://github.com/ZainRizvi due to Actually, seems like it was this commit that introduced the failure: test_maskedtensor.py::TestOperatorsCUDA::test_like_empty_like_layout1_cuda_bool [GH job link](https://github.com/pytorch/pytorch/actions/runs/10604690725/job/29392898277) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/b6e51711a0ea6174806e75ab6e208d2d910b45f5) ([comment](pytorch#128637 (comment)))
Copy link
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: sparse release notes category Reverted Stale topic: new features topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants