-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MaskedTensor support to *_like API #128637
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128637
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3201935 with merge base 92151c8 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Hi @soulitzer or @cpuhrsch, The PR is ready to merge. |
@pytorchbot rebase |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Successfully rebased |
e9cc117
to
e88526a
Compare
@pytorchbot merge |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
340cade
to
c4b46cd
Compare
I am not sure if I can use this command but as the change were approved: |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 3 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
c4b46cd
to
c32d1fd
Compare
This PR was reopened (likely due to being reverted), so your approval was removed. Please request another review.
Pull Request resolved: pytorch#128637 Approved by: https://github.com/cpuhrsch
Thank you @jeanschmidt, |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
@pytorchbot revert -c nosignal -m "Actually, seems like it was this commit that introduced the failure: test_maskedtensor.py::TestOperatorsCUDA::test_like_empty_like_layout1_cuda_bool GH job link HUD commit link" |
@pytorchbot successfully started a revert job. Check the current status here. |
@nowtryz your PR has been successfully reverted. |
This reverts commit b6e5171. Reverted #128637 on behalf of https://github.com/ZainRizvi due to Actually, seems like it was this commit that introduced the failure: test_maskedtensor.py::TestOperatorsCUDA::test_like_empty_like_layout1_cuda_bool [GH job link](https://github.com/pytorch/pytorch/actions/runs/10604690725/job/29392898277) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/b6e51711a0ea6174806e75ab6e208d2d910b45f5) ([comment](#128637 (comment)))
This PR was reopened (likely due to being reverted), so your approval was removed. Please request another review.
Pull Request resolved: #128637 Approved by: https://github.com/cpuhrsch
This reverts commit 8de56e2. Reverted #128637 on behalf of https://github.com/jeanschmidt due to Introduced API linting errors ([comment](#128637 (comment)))
Pull Request resolved: pytorch#128637 Approved by: https://github.com/cpuhrsch
This reverts commit b6e5171. Reverted pytorch#128637 on behalf of https://github.com/ZainRizvi due to Actually, seems like it was this commit that introduced the failure: test_maskedtensor.py::TestOperatorsCUDA::test_like_empty_like_layout1_cuda_bool [GH job link](https://github.com/pytorch/pytorch/actions/runs/10604690725/job/29392898277) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/b6e51711a0ea6174806e75ab6e208d2d910b45f5) ([comment](pytorch#128637 (comment)))
Pull Request resolved: pytorch#128637 Approved by: https://github.com/cpuhrsch
This reverts commit b6e5171. Reverted pytorch#128637 on behalf of https://github.com/ZainRizvi due to Actually, seems like it was this commit that introduced the failure: test_maskedtensor.py::TestOperatorsCUDA::test_like_empty_like_layout1_cuda_bool [GH job link](https://github.com/pytorch/pytorch/actions/runs/10604690725/job/29392898277) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/b6e51711a0ea6174806e75ab6e208d2d910b45f5) ([comment](pytorch#128637 (comment)))
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
No description provided.