Skip to content

[APP] Fix Gas Composition Behaviour #103

@marcusfilipesr

Description

@marcusfilipesr

The gas selection field is erasing the data when submitting the forms.

The issue is happening at the line 320 of this file, where the name of the displayed name of the column is updated based on the st.session_state[f"gas_{i}"].

To reproduce this "bug", you'll need to insert a gas composition, change the name of the gas and proceed with the forms submission. The name of the gas composition will be updated but the molar fractions will not.

I'm sharing below a couple of snapshots showing this behavior.

Image Image Image

To fix this, there are two options:

  1. Make the name of the column inside the data_editor static.
  2. Try the approach mentioned here

I will open a PR as soon as we decide which path we would like to go @raphaeltimbo and @CisneirosRaphael.

Metadata

Metadata

Labels

bugSomething isn't working

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions