Skip to content

Improve pending approval rule detection #429

@crohr

Description

@crohr

When a workflow is tied to a github environment, it may have approval rules that need acceptance before it can run. Unfortunately GitHub webhook / API is not great with regards to getting the true status of those jobs, so RunsOn prefers to wait a bit more so that GitHub internal state eventually converges to the "true" state (queued, or still waiting for approval). This is why you can see up to ~20s delay.

This should be improved, probably doing an addition check on pending deploys for the run before enqueuing.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions