Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rust-minidump/minidump-writer
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.8.4
Choose a base ref
...
head repository: rust-minidump/minidump-writer
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.8.5
Choose a head ref
  • 3 commits
  • 5 files changed
  • 3 contributors

Commits on Feb 23, 2024

  1. Bug 1847098 - Add version number of so files (#103) 

    * Bug 1847098 - Add version number of so files

* Simplify

The original code would have paniced on non-utf8 paths, and would fail to return any version components if a single one failed to be parsed as a number.

The new code will now gracefully fail if the filename (the rest of the path is inconsequential) is non-utf8, and now tries to handle as many version components as it can, including partial parsing of mixed alphanumeric components such as, eg 2rc5 (which was aready a test case) would be parsed as `25`

---------

Co-authored-by: Alexandre Lissy <lissyx@lissyx.dyndns.org>
Co-authored-by: Jake Shadle <jake.shadle@embark-studios.com>
    @lissyx @Jake-Shadle
    3 people authored Feb 23, 2024
    Configuration menu
    Copy the full SHA
    c81300e View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG

    @Jake-Shadle
    Jake-Shadle committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    e19168a View commit details
    Browse the repository at this point in the history

  3. Release 0.8.5

    @Jake-Shadle
    Jake-Shadle committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    7bf5dce View commit details
    Browse the repository at this point in the history
Loading