Skip to content

Visual artifacts in Astronaut wings, medal #299

@rnyoakum

Description

@rnyoakum

In the discussion of #192 Leon noticed visual artifacts in the Astronaut History:

Say, anyone else notice the artifacts above? The vertical line just past the astronaut wings, and the vertical colored stripe to the right of the medal? I've been looking through the museum file but can't seem to find where they're drawn, and I don't see any images for them in gamedat.
Originally posted by @peyre in #192 (comment)

I've verified this is a distinct issue from the mechanic causing the Astronaut History to crash, so I'm creating a new issue to handle it. The explanation is:

The image data is stored in arrows.but, which contains seven images used in Astronaut History:

  1. The Left All arrow icon
  2. The Double Left arrow icon
  3. The Double Right arrow icon
  4. The Right All arrow icon
  5. The USA Hero medal
  6. The USSR Hero medal
  7. Astronaut/Cosmonaut flight wings

Each image in the arrow.but file has a header at the beginning of the file, specifying the width, height, size (in bytes), and the data's location in the arrow.but file (as a byte offset from the start of the file).

For the USA Hero medal, USSR Hero medal, and flight wings, there is an error in the image data. There is a discrepancy in the width * height vs. the size, with the size - and file space allocated - being calculated as if the width was one larger. However, the listed width value is correct, the file space is too large, and every (width + 1)-th byte is simply nonsense.
Originally posted in #192 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugAn issue that causes a crash or an invalid or undesirable game state.

    Type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions