Skip to content

News event 91 doesn't occur #397

@rnyoakum

Description

@rnyoakum

The beneficial budget event

Event 91
IN THE NEWS TODAY, THE PRESIDENT HAS ANNOUNCED THAT THE SPACE PROGRAM WILL PUT A MAN ON THE MOON WITHIN THREE YEARS. FUNDING HAS INCREASED BY 20 M.B.'S TO SUPPORT THIS EFFORT.

looks like it will never trigger. Early on in the src/game/news_suq.cpp REvent() function that handles news events, there's a check

    if (Data->Year <= 65 && Data->Events[Data->Count] > 80) {
        return 1;
    }

which causes the News to skip any event ID 81+ if it would occur before 1966 (and replace it with a "flavor" event). However, in the code for event 91

    case 91:  // increase budget by 20MB's in the budget
        if (Data->Year > 65) {
            return 1;
        }

        Data->P[plr].Budget += 20;
        break;

there's a check to skip the event if the year is greater than 1965. In combination, these two checks should effectively prevent event 91 from ever being seen - which is a shame, because it's a true blessing! I'm thinking the check for event 91 is a typo, meant to stop it from triggering before '65. Because it makes more sense to have a three-year goal for a Lunar Landing set after 1965 than before, I was thinking of dropping the check in case 91.

Originally posted by @rnyoakum in #394 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugAn issue that causes a crash or an invalid or undesirable game state.

    Type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions