Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rails/sprockets
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.1.2
Choose a base ref
...
head repository: rails/sprockets
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.1.4
Choose a head ref
  • 4 commits
  • 3 files changed
  • 2 contributors

Commits on Apr 26, 2012

  1. Check for directory traversal after unescaping

    The `forbidden_request?` check could be trivially bypassed
    by percent encoding .. as %2e%2e.
    
    After auditing Sprockets and Hike and fuzzing a simple
    server, I don't believe this is exploitable. However,
    better safe than sorry/defense in depth/etc.
    jfirebaugh authored and josh committed Apr 26, 2012
    Configuration menu
    Copy the full SHA
    78fbda0 View commit details
    Browse the repository at this point in the history
  2. Sprockets 2.1.3

    josh committed Apr 26, 2012
    Configuration menu
    Copy the full SHA
    abd1827 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2014

  1. Check for absolute paths in server URL before passing to find

    Various double slashes and URL encodings can bypass current checks.
    In the case of the file existing, the server will 500 instead of 403
    which leaks the existence but not the contents of the file.
    
    Props to @eadz for finding this.
    josh committed Oct 28, 2014
    Configuration menu
    Copy the full SHA
    3043d14 View commit details
    Browse the repository at this point in the history
  2. Sprockets 2.1.4

    josh committed Oct 28, 2014
    Configuration menu
    Copy the full SHA
    0d31203 View commit details
    Browse the repository at this point in the history
Loading