When using rector in conjunction with ecs, how to be sure declare(strict_types=1) is the first statement? #7414
-
|
Hi Rector Team, Now my question is how to prevent rector and ecs stepping on their toes each other? When I run ecs without the strict rule but rector with code quality it puts the use statements at the top of the file before the declare(strict_types=1); statement which should be the first statement right after <?php when present. Is there a way to prevent this behavior? @TomasVotruba @samsonasik ? |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 9 replies
-
|
Hi, that should not happen. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks 👍 Could you add a GitHub Action with reproducible steps? That way we'll see what is wrong right in the CI and also have verification when its fixed. |
Beta Was this translation helpful? Give feedback.
-
|
To be clear nothing is wrong anymore. I think I made a mistake on my end. I cannot reproduce the "bug". locally. This repo is just an example for me and others nothing to do with the bug I told you about above. At first I tried to do it for the bug. But finally I decided to let it go to the github universe flying in alternative world between the stars and the code. BTW thanks for sharing this month jetbrains blog issue. Cool for rector and I found many new tools listed in the blog post useful and cool. Thanks. |
Beta Was this translation helpful? Give feedback.
-
|
Alright then 😌👍 |
Beta Was this translation helpful? Give feedback.
-
|
No problem Tomas. I am happy to learn from a humble superstar like you. |
Beta Was this translation helpful? Give feedback.
-
|
Same for me, I'm learning from all the open-source leaders and every contributor like you, Thank you for warm words 🙇 |
Beta Was this translation helpful? Give feedback.
Hi, that should not happen.
we'll need a demo link with particular Rector rule and invalid code.