Skip to content

Calculation of fees based on the library of the renewal or checkin, instead of the library of the checkout #2683

@pronguen

Description

@pronguen

Describe the bug

In most of the cases, fees are calculated correctly. In some cases though, they are counted on closed days.

Hypothesis to verify: maybe the fees takes as basis the checkin library opening hours and exception days.

To Reproduce

Unknown, see hypothesis above

Expected behavior

Calculation of overdue incremental fees always takes as basis the checkout library opening hours and exception days.

Context

  • server: bib.rero.ch
  • version: v1.8.0

Example 1

  • Loan pid:269879
  • Applied cipo is pid:22
  • Item library pid:30 (La Chaux-de-Fonds)
  • Checkout library pid:30 (La Chaux-de-Fonds)
  • After last renewal, loan due date was 23.12.21
  • La Chaux-de-Fonds was closed on 24-26.12
  • Grace period (4 days) was applied on 27-30.12
  • La Chaux-de-Fonds was closed on 31.12-03.01
  • Fees started on 03.01 instead of 04.01

Other examples of this error exist in the same user account (fees of CHF 4.-). All are item of La Chaux-de-Fonds checked out in La Chaux-de-Fonds, but checked in in Neuchâtel. Maybe the fees takes as basis the checkin library opening hours and exception days. Indeed, Neuchatel was open on 03.01.

image

Metadata

Metadata

Assignees

Labels

bugBreaks something but is not blockingf: circulationConcerns the circulation interface or backend

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions