Skip to content

SyntaxWarning: "is not" with a literal #2713

@phillxnet

Description

@phillxnet

With our recent Python version updates we are now seeing the following warnings when running our tests within an rpm build environment:

cd src/rockstor/
poetry run django-admin test
/src/rockstor/system/luks.py:241: SyntaxWarning: "is not" with a literal. Did you mean "!="?
if container_dev is not "":
/src/rockstor/system/luks.py:351: SyntaxWarning: "is not" with a literal. Did you mean "!="?
if len(source_dev_fields) is not 2:
/src/rockstor/storageadmin/views/email_client.py:204: SyntaxWarning: "is not" with a literal. Did you mean "!="?
if len(line) > 0 and line[0] is not "#":
/src/rockstor/storageadmin/views/rockon_helpers.py:239: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if new_state is not "pending_update" and task is not None:
/src/rockstor/storageadmin/views/rockon_helpers.py:239: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if new_state is not "pending_update" and task is not None:
/src/rockstor/storageadmin/views/rockon_helpers.py:379: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if c.uid is -1:
Creating test database for alias 'default'...
Creating test database for alias 'smart_manager'...

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions