-
Notifications
You must be signed in to change notification settings - Fork 95
Closed
Description
Hi @PNejr10 ,
Thank you for the PRs #85, #86, and #87. Could you please elaborate a bit on the changes, their rationale, etc. because none of the PRs does provide any description, nor is there an issue for them.
I've only briefely scrolled over the changes and I have some doubts accepting them, to be honest. I understand that some changes would probably make the code a bit more compact. However, I argue that it is sometimes written the way it was written because the original author wanted it that way. For example, removing comments is IMHO almost never a good thing to do.
Looking forward to your reply.
Best,
Stephan
Metadata
Metadata
Assignees
Labels
No labels