Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: shaka-project/shaka-player
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.15.18
Choose a base ref
...
head repository: shaka-project/shaka-player
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.15.19
Choose a head ref
  • 20 commits
  • 29 files changed
  • 4 contributors

Commits on Oct 23, 2025

  1. Configuration menu
    Copy the full SHA
    5a7f2f0 View commit details
    Browse the repository at this point in the history
  2. fix(Ads): Do not start interstitials when the main video paused (#9242)

    IMA has the same behavior
    
    Fixes #9240
    avelad committed Oct 23, 2025
    Configuration menu
    Copy the full SHA
    035db3d View commit details
    Browse the repository at this point in the history
  3. fix(Xbox): Implement requiresClearAndEncryptedInitSegments method for…

    … xbox (#9254)
    
    ### Summary
    When playing a live HLS stream on Xbox, I was running into the following
    error as soon as the playhead hit a discontinuity:
    
    ```
    CHUNK_DEMUXER_ERROR_APPEND_FAILED: Sample encryption info is not available.
    ```
    
    I noticed that [this
    fix](#6719) was added
    a while back to address this exact issue. A few months ago, [another
    PR](#8210) was
    submitted to abstract the feature detection logic, which I believe
    unfortunately caused a regression.
    
    The `requiresClearAndEncryptedInitSegments` helper was implemented in
    both the Abstract Device and the Default Browser, but it looks like it
    wasn't implemented in the Xbox class. This resulted in
    `requiresClearAndEncryptedInitSegments` always returning false on that
    platform (defaulting to the Abstract Device class's implementation,
    which returns `false`).
    
    This made the following logic (that fixed the
    CHUNK_DEMUXER_ERROR_APPEND_FAILED error) fail:
    ```
    if (device.requiresClearAndEncryptedInitSegments()) {
      const doubleInitSegment = new Uint8Array(initSegment.byteLength +
        modifiedInitSegment.byteLength);
      doubleInitSegment.set(modifiedInitSegment);
      doubleInitSegment.set(initSegment, modifiedInitSegment.byteLength);
      return doubleInitSegment;
    }
    ```
    
    ### Fix
    Overriding this function in the Xbox class fixes the problem. 
    
    ### Result
    Playback now proceeds through HLS discontinuities on Xbox without
    CHUNK_DEMUXER_ERROR_APPEND_FAILED.
    subhanahmed047 authored and avelad committed Oct 23, 2025
    Configuration menu
    Copy the full SHA
    d922439 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6b2c574 View commit details
    Browse the repository at this point in the history
  5. perf: Optimize restrictions check (#9261)

    Current ManifestFilterer logic checks all variants and throws
    RESTRICTIONS_CANNOT_BE_MET if none of variants is playable. It's
    redundant, because if at least one variant is playable, we will not emit
    this error anyway, so we can quickly stop further processing if we
    detect playable variant.
    tykus160 authored and avelad committed Oct 23, 2025
    Configuration menu
    Copy the full SHA
    131f183 View commit details
    Browse the repository at this point in the history
  6. fix(UI): Always show thumbnail position in the correct place (#9264)

    This fixes the bug where getThumbnails takes some time and the thumbnail
    container is displayed in an incorrect position in the seekbar
    avelad committed Oct 23, 2025
    Configuration menu
    Copy the full SHA
    b48f85d View commit details
    Browse the repository at this point in the history
  7. fix(webOS): Disable smooth codec switch on webOS (#9273)

    During my tests I wasn't able to find a webOS TV which could handle
    smooth codec switching properly. Let's disable it on all platform,
    similar to what we've done on Tizen back in the day.
    tykus160 authored and avelad committed Oct 23, 2025
    Configuration menu
    Copy the full SHA
    4573785 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2025

  1. Configuration menu
    Copy the full SHA
    0907686 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    386f7cc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    57c4cee View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3da4cf4 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c2a644b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    20fb61f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    0aa88e0 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    50c92bd View commit details
    Browse the repository at this point in the history
  9. ci: Use python3 explicitly (#9288)

    As python v3 is now necessary in our build pipeline, use python3
    explicitly in CI and tutorials, as not all OSes symlink `python` to
    `python3`.
    tykus160 authored and avelad committed Oct 27, 2025
    Configuration menu
    Copy the full SHA
    06aa706 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    582f726 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    3f21ecc View commit details
    Browse the repository at this point in the history
  12. fix(UI): Allow play in VR in all compatible devices (#9297)

    Since VR movement can be controlled with specific methods we should not
    limit its use
    avelad committed Oct 27, 2025
    Configuration menu
    Copy the full SHA
    139bb7a View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    76027a7 View commit details
    Browse the repository at this point in the history
Loading