-
Notifications
You must be signed in to change notification settings - Fork 24
Open
Labels
enhancementNew feature or requestNew feature or request
Description
It's bothered me ever since the beginning that if you want to set or get some key within sigmf you needed to do sigmf.SigMFFile.VERSION_KEY instead of just doing sigmf.VERSION_KEY. Now we appear to also have keys within archive.py for file extensions, which is strange.
Other modules (logging, pygame, numpy) have global vars like this in the top level.
I would like to:
- Consolidate all keys into
keys.pyor similar name. - In the
__init__.pydofrom .keys import *so that we can access a key usingsigmf.VERSION_KEY. - In
SigMFFileattach keys as properties for now and insert a comment saying that functionality will be deprecated in a future version. This keeps backwards compatibility.
This change should increment the minor version (major.minor.patch).
gmabey and GreenK173
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request