Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[introduction-to-codeql] - resolves template not loading when starting course #5

Merged
merged 4 commits into from
Oct 23, 2023

Conversation

felickz
Copy link
Contributor

@felickz felickz commented Oct 23, 2023

Summary

Before:

start-course

image

After:

start-course

image

Changes

Fixes link in start course

Closes:

Task list

  • For workflow changes, I have verified the Actions workflows function as expected.
  • For content changes, I have reviewed the style guide.

@felickz felickz changed the title resolves template not loading when starting course [introduction-to-codeql] - resolves template not loading when starting course Oct 23, 2023
README.md Outdated Show resolved Hide resolved
Copy link

@hectorsector hectorsector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggestion prefixes the user's repo with skills- which makes them easier to spot in their repo list. Other than that, looks good to me!

README.md Outdated Show resolved Hide resolved
@hectorsector
Copy link

Quick heads up on 8ac9691, after this commit the name of the user's repo will actually not match the name of the skill. I don't think that's intended so wanted to flag it for y'all.

@leftrightleft
Copy link
Contributor

Quick heads up on 8ac9691, after this commit the name of the user's repo will actually not match the name of the skill. I don't think that's intended so wanted to flag it for y'all.

Just fixed. Thanks @hectorsector

@leftrightleft leftrightleft merged commit 8cdd947 into main Oct 23, 2023
@leftrightleft leftrightleft deleted the start-course-link branch October 23, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants