Skip to content

[Bug]: tsp-toolkit depends on private repos, building impossible. #16

@956MB

Description

@956MB

Tracking

  • Add more contributing documentation

Pre-check

  • I have searched the existing issues and discussions to make sure my problem has not already been addressed.
  • I have looked at the "Known Issues" Section of the marketplace page of all TSP Toolkit extensions.

This project's dependencies currently contains three private repos, @tektronix/keithley_instrument_libraries, @tektronix/kic-cli, and @tektronix/web-help-documents, making work on the extension impossible.

  • macOS Sonoma 14.4.1 (23E224)
  • Node v18.17.1
  • pnpm v9.0.6
  • tsp-toolkit commit e1f6d57

TSP Toolkit Version

0.15.0

TSP Toolkit Develop Version

0.15.0

Steps to Reproduce

  1. Fork tsp-toolkit
  2. Clone (git clone https://github.com/956MB/tsp-toolkit.git)
  3. Run pnpm install:
 ERR_PNPM_FETCH_401  GET https://npm.pkg.github.com/@tektronix%2Fkeithley_instrument_libraries: Unauthorized - 401
  1. Delete "@tektronix/web-help-documents": "0.15.0", from package.json
  2. Run pnpm install again:
 ERR_PNPM_FETCH_401  GET https://npm.pkg.github.com/@tektronix%2Fweb-help-documents: Unauthorized - 401
  1. Delete "@tektronix/kic-cli": "0.15.1", from package.json
  2. Run pnpm install again:
 ERR_PNPM_FETCH_401  GET https://npm.pkg.github.com/@tektronix%2Fweb-help-documents: Unauthorized - 401
  1. Delete last line "@tektronix/keithley_instrument_libraries": "0.15.0", from package.json
  2. Running pnpm install this last time installs fine with no errors, but then obviously we don't have the packages needed for COMMAND_SETS and EXECUTABLE in src/extension.ts, and elsewhere:
import { COMMAND_SETS } from "@tektronix/keithley_instrument_libraries"
import { EXECUTABLE } from "@tektronix/kic-cli"

// ├╴E  Cannot find module '@tektronix/keithley_instrument_libraries' or its corresponding type declarations. typescript (2307) [5, 29]
// ├╴E  Cannot find module '@tektronix/kic-cli' or its corresponding type declarations. typescript (2307) [6, 27]

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions