Skip to content

Revise can fail on revising function defined via metaprogramming #643

@aviatesk

Description

@aviatesk

Reduced to this MRE:

mre.jl

macro deffoo()
    sig = GlobalRef(__module__, :foo)
    quote
        $sig(args...) = length(args) + 2
    end
end

@deffoo
@show foo(1,2,3)
julia> using Revise; includet("mre.jl")
foo(1, 2, 3) = 5
ERROR: TypeError: in typeassert, expected Symbol, got a value of type QuoteNode
Stacktrace:
 [1] includet(mod::Module, file::String)
   @ Revise ~/julia/packages/Revise/src/packagedef.jl:1011
 [2] includet(file::String)
   @ Revise ~/julia/packages/Revise/src/packagedef.jl:1016
 [3] top-level scope
   @ REPL[2]:1

caused by: TypeError: in typeassert, expected Symbol, got a value of type QuoteNode
Stacktrace:
 [1] identify_framemethod_calls(frame::JuliaInterpreter.Frame)
   @ LoweredCodeUtils ~/julia/packages/LoweredCodeUtils/src/signatures.jl:155
 [2] rename_framemethods!
   @ ~/julia/packages/LoweredCodeUtils/src/signatures.jl:294 [inlined]
 [3] methods_by_execution!(recurse::Any, methodinfo::Revise.CodeTrackingMethodInfo, docexprs::Dict{Module, Vector{Expr}}, mod::Module, ex::Expr; mode::Symbol, disablebp::Bool, always_rethrow::Bool, kwargs::Base.Pairs{Symbol, Bool, Tuple{Symbol}, NamedTuple{(:skip_include,), Tuple{Bool}}})
   @ Revise ~/julia/packages/Revise/src/lowered.jl:191
 [4] #eval_with_signatures#92
   @ ~/julia/packages/Revise/src/packagedef.jl:463 [inlined]
 [5] instantiate_sigs!(modexsigs::OrderedCollections.OrderedDict{Module, OrderedCollections.OrderedDict{Revise.RelocatableExpr, Union{Nothing, Vector{Any}}}}; mode::Symbol, kwargs::Base.Pairs{Symbol, Bool, Tuple{Symbol}, NamedTuple{(:skip_include,), Tuple{Bool}}})
   @ Revise ~/julia/packages/Revise/src/packagedef.jl:471
 [6] track(mod::Module, file::String; mode::Symbol, kwargs::Base.Pairs{Symbol, Bool, Tuple{Symbol}, NamedTuple{(:skip_include,), Tuple{Bool}}})
   @ Revise ~/julia/packages/Revise/src/packagedef.jl:899
 [7] includet(mod::Module, file::String)
   @ Revise ~/julia/packages/Revise/src/packagedef.jl:994
 [8] includet(file::String)
   @ Revise ~/julia/packages/Revise/src/packagedef.jl:1016
 [9] top-level scope
   @ REPL[2]:1

I think I have a fix, will make a PR on LoweredCodeUtils.jl to fix this issue.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions