-
Notifications
You must be signed in to change notification settings - Fork 6
Open
Labels
good first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed
Description
Currently, js_sys::Reflect::set is used to convert JsRow to JsValue. It is better to implement it in a more efficient and elegant way.(via stdweb, for example)
Lines 215 to 220 in 5ced68a
| for col in row.cols { | |
| match col.value { | |
| Value::Null => { | |
| js_sys::Reflect::set(&object, &col.name.unwrap().into(), &JsValue::null()) | |
| .unwrap(); | |
| } |
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed