Replies: 2 comments
-
|
@jpkanter, the https://github.com/vufind-org/vufind/blob/dev/config/vufind/config.ini#L2552-L2555 The reason for the inconsistency is that favorites are a social feature that have a broader scope than a search backend. Items in favorites can come from any backend. So the limit settings in searches.ini apply to Solr, the limit settings in EDS.ini apply to EDS, etc., etc. Favorites apply to EVERYTHING, and so these settings are in the universal primary configuration file, config.ini. Does that help? |
Beta Was this translation helpful? Give feedback.
-
|
Yes, it does. I can see now why the got the |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
While working on an issue today I stumbled upon a weird inconsistency in regards of favorites:
If one, for any reasons, wants to adjusts the number for displayed favorites on the myresearch page or add a control widget for the amount of entries per page ones needs to add a new section to the main config named
[Social]and the parameters are then namedlists_default_limitandlists_limit_optionsthis is unlike the "real" search options that are nameddefault_limitandlimit_optionsI only found this after delving deeply into the code, namely
Search/Favorites/Options.phpto find the offending text:According to codeblame this is almost a decade old code (last edited 2016-04-25 22:09 GMT+1), I did not wanted to open a pull request from the get go as this is a breaking change for all instances that modify this parameter. Also I put in zero research to see where else this parameter is used.
If its nowhere I would propose moving this parameter to the
searches.iniunder either[Favorites]or if broader used[MyResearch]and the properly named as the normal parameters that govern this feature for the search.Beta Was this translation helpful? Give feedback.
All reactions