-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-writing-modes] white space collapsing/processing in text-combine horizontal #4139
Labels
Closed Accepted by CSSWG Resolution
css-writing-modes-3
css-writing-modes-4
Current Work
Tested
Memory aid - issue has WPT tests
Tracked in DoC
Comments
frivoal
changed the title
[css-writing-modes] white space collapsing in text-combine horizontal
[css-writing-modes] white space collapsing/processing in text-combine horizontal
Jul 21, 2019
fantasai
added a commit
that referenced
this issue
Jul 21, 2019
…of a TCY combination. #4139 see also thread at <https://lists.w3.org/Archives/Public/www-style/2018Aug/0019.html>.
Fixed in 53a5349 |
frivoal
added a commit
to frivoal/wpt
that referenced
this issue
Jul 22, 2019
frivoal
added a commit
to frivoal/wpt
that referenced
this issue
Jul 22, 2019
(cc myself in case something needs to be done in Gecko) |
The CSS Working Group just discussed
The full IRC log of that discussion<dael> TOpic: white space collapsing/processing in text-combine horizontal<dael> github: https://github.com//issues/4139#issuecomment-513589921 <dael> fantasai: There was an issue on www-style on how we handle whitespace at the beginning of a [missed] string where we want all text combined. Spaces within text straightforward how it's for whitespace, but question on start and end <fantasai> https://github.com/w3c/csswg-drafts/commit/53a5349823a794923be057e29038e021f523451f <dael> fantasai: Makes sense handled same as if inline block. Collapsible whitespace is collapsed away. Changes to make this explicit. Currently say composition of text is as if inline block. Makes it explicit whitespace collapses in that manner. <dael> astearns: Matches impl except Safari. THere's a safari engineer to make the change? <dael> fantasai: I haven't tested all impl. Safari engineer said it's reasonable <dael> Rossen_: For the TR portion or writing modes? <dael> fantasai: For L3 <dael> Rossen_: Why make this behavior change that late? <dbaron> s/[missed]/tate-chu-yoko (縦中横)/ <dael> florian: Clarification, not behavior change. Already said lay text out as if inlineblock. Points out that that means you have to handle whitespace at beginning and end in a specific way <fantasai> Looks like Gecko would need changes to comply <dael> Rossen_: Proposing add a note <dael> fantasai: Proposing addnormative text <dael> florian: It's clarification of existing text that says do layout as inline block. It's phrased as normative that you're supposed to layout as inline block which means do this thing and pointing to css text <dael> Rossen_: What would be effect...reading to catch up on IRC. Listing to fantasai and she was saying we will have to enter CR for this? <fantasai> testcase http://software.hixie.ch/utilities/js/live-dom-viewer/?%3C!DOCTYPE%20html%3E%0A%3Cp%20style%3D%22writing-mode%3A%20vertical-rl%22%3EA%3Cspan%20style%3D%22text-combine-upright%3A%20all%22%3Etext%3C%2Fspan%3E%3Cspan%20style%3D%22text-combine-upright%3A%20all%22%3Etext%20%20%3C%2Fspan%3EB%3C%2Fp%3E <dael> florian: Already have to go through CR due to other changes. Since there was some disagreement on what this meant we clarify <dael> AmeliaBR: L3 and L4 are as CR we're republish CR anyways. <dael> florian: As fantasai mentioned a safari engineer was wlling to change. afaict this does not match impl though it matches spec <dael> astearns: Rossen_ was asking process. We'd like L3 as fast as possible. If we clarify we need to update test suite and make sure we have enough impl passing. From process might be easier to clarify in L4. <dael> florian: L3 needs to republish anyway so no difference. In terms of passing maybe. Given disagreement leaving it undefined for now and clarify in L4 might make it easier for publications <dael> fantasai: In at risk? <dael> Rossen_: THought it was. <dael> florian: All value is in L3. Automatic was at risk and removed. Behavior wasn't at risk. <dael> astearns: And putting this in L3 at risk if we take it out means there'sanother publishing churn <dael> florian: No, at risk you can remove without repub <dael> astearns: True <dael> florian: Need new CR due to other nromative changes <dael> astearns: Why nec to put in L3 given L4 is the thing we're working on. Clarifications in later modules is appropriate <dael> florian: Given L3 text is ambig if we want it in L4 we can explicit undefine in L3. Does that work for you fantasai ? <dael> fantasai: Seems fine <dael> astearns: Prop: Make this undefined in L3. Define interop behavior in L4 and add tests to L4 test suite <dael> florian: I've written the tests <dael> astearns: Excellent <dael> astearns: Objections to Make this undefined in L3. Define interoperable behavior in L4 and add tests to L4 test suite <dael> RESOLVED: Make this undefined in L3. Define interoperable behavior in L4 and add tests to L4 test suite <dael> florian: Only open issues on writing modes are expected to be resolved editorially. Can we repub CR with other changes and this resolution? <dael> florian: Editorial can happen without patent wait. We have normative edits so pushing those seems useful <dael> astearns: sgtm <dael> Rossen_: List of editorial changes? <dael> florian: It's open issues <AmeliaBR> Changes already integrated in ED: https://drafts.csswg.org/css-writing-modes/#changes-201805 <dael> Rossen_: [missed] having test suite complied against the PR which was the organized test suite. Have we changed version for retest? <AmeliaBR> Open issues: https://github.com/w3c/csswg-drafts/labels/css-writing-modes-3 <dael> florian: Impl report I'm planning to update. Would like to update on basis of CR. We have open issues fantasai thinks will be editorial. Not proven. If are editorial we can roll them in.I'm trying to update impl report from koji but easier against CR <AmeliaBR> Whoops, above link was level 4 changes, here is level 3: https://drafts.csswg.org/css-writing-modes-3/#changes-201805 <dael> astearns: And against most recent CR is what will satisfy review <dael> florian: And if we need changes it's easier to change something scoped. A stake in the ground now would be helpful. <dael> Rossen_: It is disappointing to see it's been so long since we were almost REC with so much work. We have another meeting in Japan and I'm sure folks there will be interested in progress. DOesn't sound like we're close to ready. <dael> Rossen_: THis is quite disappointing to see we are where we are. We're trying to get more and more into this spec which means it'll take longer and longer and not focus on L4 <dael> florian: That's what I'm trying to do. Get to PR or know why we can't so that we publish what we have resolved on and update koji's report. Not sure we'll be at PR but updating the report is the first step to know if we can. <fantasai> No, they're geared towards me :p <dael> Rossen_: This is fantastic. Comments aren't toward you and I appriciate the effort you put. We as a group are tending to try and put more into L3 rather then get it out the door. Your efforts are appricated <dael> astearns: Proposal is publish updated CR of Writing Modes L3 <dael> RESOLVED: publish updated CR of Writing Modes L3 <dael> astearns: Any other writing modes progress we can make? |
frivoal
added a commit
to frivoal/csswg-drafts
that referenced
this issue
Jul 24, 2019
…ne-upright for L3 See w3c#4139
frivoal
added
css-writing-modes-4
Current Work
Closed Accepted by CSSWG Resolution
Needs Review of Proposed Text
labels
Jul 24, 2019
frivoal
added
Tested
Memory aid - issue has WPT tests
Tracked in DoC
and removed
Needs Testcase (WPT)
labels
Jul 26, 2019
frivoal
added a commit
to web-platform-tests/wpt
that referenced
this issue
Jul 26, 2019
aarongable
pushed a commit
to chromium/chromium
that referenced
this issue
Jul 26, 2019
These tests are for an edge case that is resolved[1] to be undefined in CSS Writing Modes Level 3, and the new behavior is defined in Level 4. We don't have a plan to implement Level 4 yet. These tests will be moved back when it starts. [1] w3c/csswg-drafts#4139 TBR: eae@chromium.org Bug: 987976 Change-Id: I08056a2d3f49ec04ade3aa1ced848b8a418cc51f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720866 Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#681416}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this issue
Aug 5, 2019
…rafts#4139, a=testonly Automatic update from web-platform-tests [css-writing-modes] tests for w3c/csswg-drafts#4139 (#17970) -- wpt-commits: d1f5c9552ae7b12a74c97ad69cdf662c8cbfd263 wpt-pr: 17970
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this issue
Aug 5, 2019
…rafts#4139, a=testonly Automatic update from web-platform-tests [css-writing-modes] tests for w3c/csswg-drafts#4139 (#17970) -- wpt-commits: d1f5c9552ae7b12a74c97ad69cdf662c8cbfd263 wpt-pr: 17970
natechapin
pushed a commit
to natechapin/wpt
that referenced
this issue
Aug 23, 2019
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this issue
Oct 4, 2019
…rafts#4139, a=testonly Automatic update from web-platform-tests [css-writing-modes] tests for w3c/csswg-drafts#4139 (#17970) -- wpt-commits: d1f5c9552ae7b12a74c97ad69cdf662c8cbfd263 wpt-pr: 17970 UltraBlame original commit: 4e8d403ac190bcae825cd55e9267c8149f9a18fd
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this issue
Oct 4, 2019
…rafts#4139, a=testonly Automatic update from web-platform-tests [css-writing-modes] tests for w3c/csswg-drafts#4139 (#17970) -- wpt-commits: d1f5c9552ae7b12a74c97ad69cdf662c8cbfd263 wpt-pr: 17970 UltraBlame original commit: 4e8d403ac190bcae825cd55e9267c8149f9a18fd
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this issue
Oct 4, 2019
…rafts#4139, a=testonly Automatic update from web-platform-tests [css-writing-modes] tests for w3c/csswg-drafts#4139 (#17970) -- wpt-commits: d1f5c9552ae7b12a74c97ad69cdf662c8cbfd263 wpt-pr: 17970 UltraBlame original commit: 4e8d403ac190bcae825cd55e9267c8149f9a18fd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Closed Accepted by CSSWG Resolution
css-writing-modes-3
css-writing-modes-4
Current Work
Tested
Memory aid - issue has WPT tests
Tracked in DoC
This was previously filed as a mail. Reproducing its content here:
@fantasai replied:
Yuki Sekiguchi then replied:
The text was updated successfully, but these errors were encountered: