Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 'readonly' attribute should be mapped to ATK_STATE_READ_ONLY #93

Closed
joanmarie opened this issue Jun 16, 2017 · 4 comments
Closed

The 'readonly' attribute should be mapped to ATK_STATE_READ_ONLY #93

joanmarie opened this issue Jun 16, 2017 · 4 comments
Assignees
Milestone

Comments

@joanmarie
Copy link
Contributor

The 'readonly' attribute should be mapped to ATK_STATE_READ_ONLY.

@joanmarie
Copy link
Contributor Author

Looking closer, why isn't the attribute mapped to aria-readonly="true"?

@LJWatson LJWatson added this to the WD for wide review milestone Jun 17, 2017
@jasonkiss
Copy link
Contributor

Good question. The mappings for aria-readonly=true appear a match for all platforms/APIs but AXAPI.

Currently the HTML-AAM has AXEnabled: NO for readonly, but "AXValue: the AXUIElementIsAttributeSettable method returns NO" for aria-readonly=true.

AXEnabled:NO seems wrong, and doesn't match what webkit is doing. But I can't confirm if the AXUIElementIsAttributeSettable method returns NO with AXValue. @cookiecrook or @fleizach, are we safe to map HTML readonly to aria-readonly="true" where AXAPI is concerned?

@cookiecrook
Copy link
Collaborator

are we safe to map HTML readonly to aria-readonly="true" where AXAPI is concerned?

Yes. I believe so.

AXEnabled:NO seems wrong, and doesn't match what webkit is doing. But I can't confirm if the AXUIElementIsAttributeSettable method returns NO with AXValue.

Yeah, I agree that seems wrong. AXEnabled should map inversely to disabled/aria-disabled rather than readonly but perhaps some piece of the chain assumes that readonly is a superset of disabled? @fleizach may know.

@jasonkiss jasonkiss self-assigned this Dec 12, 2017
jasonkiss added a commit that referenced this issue Dec 18, 2017
@jasonkiss
Copy link
Contributor

bb106b9: Have updated all mappings for readonly to use CORE-AAM mappings for aria-readonly=true. If there are any issues, particularly with AXAPI (ping @fleizach?), can reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants