Skip to content

The 'readonly' attribute should be mapped to ATK_STATE_READ_ONLY #93

Closed

Description

@joanmarie

The 'readonly' attribute should be mapped to ATK_STATE_READ_ONLY.

Activity

  1. joanmarie commented on Jun 16, 2017

    @joanmarie
    ContributorAuthor

    Looking closer, why isn't the attribute mapped to aria-readonly="true"?

  2. added this to the milestone on Jun 17, 2017
  3. jasonkiss commented on Jul 26, 2017

    @jasonkiss
    Contributor

    Good question. The mappings for aria-readonly=true appear a match for all platforms/APIs but AXAPI.

    Currently the HTML-AAM has AXEnabled: NO for readonly, but "AXValue: the AXUIElementIsAttributeSettable method returns NO" for aria-readonly=true.

    AXEnabled:NO seems wrong, and doesn't match what webkit is doing. But I can't confirm if the AXUIElementIsAttributeSettable method returns NO with AXValue. @cookiecrook or @fleizach, are we safe to map HTML readonly to aria-readonly="true" where AXAPI is concerned?

  4. cookiecrook commented on Jul 26, 2017

    @cookiecrook
    Collaborator

    are we safe to map HTML readonly to aria-readonly="true" where AXAPI is concerned?

    Yes. I believe so.

    AXEnabled:NO seems wrong, and doesn't match what webkit is doing. But I can't confirm if the AXUIElementIsAttributeSettable method returns NO with AXValue.

    Yeah, I agree that seems wrong. AXEnabled should map inversely to disabled/aria-disabled rather than readonly but perhaps some piece of the chain assumes that readonly is a superset of disabled? @fleizach may know.

  5. self-assigned this
    on Dec 12, 2017
  6. jasonkiss commented on Dec 18, 2017

    @jasonkiss
    Contributor

    bb106b9: Have updated all mappings for readonly to use CORE-AAM mappings for aria-readonly=true. If there are any issues, particularly with AXAPI (ping @fleizach?), can reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions