Add rename_constraint operation
#293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexis Rico <sferadev@gmail.com>
SferaDev
commented
Mar 1, 2024
There was a problem hiding this comment.
Looks good 👍 Thanks for doing it 🙏
We also need:
- An example migration in
/examples. Either add a migration to create a table with a constraint then another migration to rename it, or just add a migration to rename one of the constraints created in an existing example. - Update the
docs/README.mdfile operations reference section.
Signed-off-by: Alexis Rico <sferadev@gmail.com>
Signed-off-by: Alexis Rico <sferadev@gmail.com>
Signed-off-by: Alexis Rico <sferadev@gmail.com>
andrew-farries
approved these changes
Mar 1, 2024
andrew-farries
added a commit
that referenced
this pull request
Mar 4, 2024
Add a CI step to validate that the example migrations are valid according to the JSON schema. This would have caught the problem where the JSON schema was not fully updated in #293 and had to be updated in a follow-up PR #300 despite #293 including an example migration. Use [ajv-cli](https://ajv.js.org/packages/ajv-cli.html) to perform schema validation. Here is an [example run](https://github.com/xataio/pgroll/actions/runs/8113707179/job/22177613982) where the check fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the frontend when renaming a column we were adding
OpRawSQLoperations thatALTER TABLE "${tableName}" RENAME CONSTRAINT "${oldName}" TO "${newName}";to keep the constraints up to date for the data api to like them. Proposing to expose a new operation for that use case.Before merging, an example should be added for the new operation.