Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rename_constraint operation to PgRollOperation JSON schema definition #300

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

andrew-farries
Copy link
Collaborator

Otherwise migrations that include this operation are not valid according to the JSON schema.

Fixup to #293.

@andrew-farries andrew-farries merged commit eda936f into main Mar 1, 2024
42 checks passed
@andrew-farries andrew-farries deleted the add-rename-constraint-op-to-op-list branch March 1, 2024 16:02
andrew-farries added a commit that referenced this pull request Mar 4, 2024
Add a CI step to validate that the example migrations are valid
according to the JSON schema.

This would have caught the problem where the JSON schema was not fully
updated in #293 and had to be
updated in a follow-up PR #300
despite #293 including an example migration.

Use [ajv-cli](https://ajv.js.org/packages/ajv-cli.html) to perform
schema validation.

Here is an [example
run](https://github.com/xataio/pgroll/actions/runs/8113707179/job/22177613982)
where the check fails.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants