Skip to content

Not compatible stratum #147

@sammy007

Description

@sammy007

xmrig checks jobid in setId() method of the class JobID which must be at least 4 bytes long to pass the check.

https://github.com/sammy007/monero-stratum/issues/60#issuecomment-335088449

Such requirement is incorrect.

diff -ur xmrig_orig/src/net/JobId.h xmrig/src/net/JobId.h
--- xmrig_orig/src/net/JobId.h	2017-10-09 03:22:24.733266554 -0400
+++ xmrig/src/net/JobId.h	2017-10-09 03:23:04.392712944 -0400
@@ -63,7 +63,7 @@
         }
 
         const size_t size = strlen(id);
-        if (size < 4 || size >= sizeof(m_data)) {
+        if (size >= sizeof(m_data)) {
             return false;
         }
 

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions