Darkside TXIDs are incorrect

**What is the bug?**
Darkside txids are incorrect

**Additional context**
In a production server, the txid issue is bypassed according to this comment: https://github.com/zcash/lightwalletd/blob/8003d7fb6e3c47fb0561121a0ee47d080c8c46b9/common/common.go#L262-L267

This doesn't help on darkside, though
https://github.com/zcash/lightwalletd/blob/8003d7fb6e3c47fb0561121a0ee47d080c8c46b9/common/darkside.go#L99-L103

Zingo, and I believe some other lightwallets (although I haven't investigated this), when it sends a transaction, it calculates the transaction ID of the transaction it's submitting, and is then confused when the on-chain txid doesn't match what it deterministically should be.   

	func getBlockFromRPC(height int) (*walletrpc.CompactBlock, error) {
	// `block.ParseFromSlice` correctly parses blocks containing v5
	// transactions, but incorrectly computes the IDs of the v5 transactions.
	// We temporarily paper over this bug by fetching the correct txids via a
	// verbose getblock RPC call, which returns the txids.
	//

	func darksideSetTxID(tx *parser.Transaction) {
	// SHA256d
	// This is correct for V4 transactions, but not for V5, but in this test
	// environment, it's harmless (the incorrect txid calculation can't be
	// detected). This will be fixed when lightwalletd calculates txids correctly .

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Darkside TXIDs are incorrect #456

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Darkside TXIDs are incorrect #456

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions