Fire mw.hook() event as soon as edit page rearrangement has been completed
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	PerfektesChaos
	Nov 15 2017, 9:09 AM

Description

When ext.proofreadpage.page.edit.js in rEPRP terminated its job, some event should be launched like:

mw.hook( "ext.gadget.proofread.page.ready" ).fire( something? );

This might help various ”asynchronous execution“ problems mentioned in T119324#2070849 as well.

Details

	Subject	Repo	Branch	Lines +/-
	OSD: Add a ready hook for scripts	mediawiki/extensions/ProofreadPage	wmf/1.38.0-wmf.9	+5 -0
	OSD: Add a ready hook for scripts	mediawiki/extensions/ProofreadPage	master	+5 -0

Customize query in gerrit

Related Objects

Mentioned Here: T119324: Extension or User based elements added to the default WikiEditor toolbar are not loaded in certain namespaces and/or instances

Event Timeline

PerfektesChaos created this task.Nov 15 2017, 9:09 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 15 2017, 9:10 AM

PerfektesChaos updated the task description. (Show Details)Nov 15 2017, 9:11 AM

PerfektesChaos updated the task description. (Show Details)

That's definitely a good idea! Let's add it to the TODO list.

Tpt moved this task from Backlog to Top priority on the ProofreadPage board.Nov 15 2017, 10:19 AM

THE_IT subscribed.Nov 16 2017, 12:29 AM

Change 740324 had a related patch set uploaded (by Inductiveload; author: Inductiveload):

[mediawiki/extensions/ProofreadPage@master] OSD: Add a ready hook for scripts

https://gerrit.wikimedia.org/r/740324

gerritbot added a project: Patch-For-Review.Nov 21 2021, 12:02 PM

Change 740324 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] OSD: Add a ready hook for scripts

https://gerrit.wikimedia.org/r/740324

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Nov 21 2021, 3:00 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 21 2021, 3:10 PM

Inductiveload moved this task from Top priority to Done: to deploy/check on the ProofreadPage board.Nov 21 2021, 5:39 PM

Change 740778 had a related patch set uploaded (by Inductiveload; author: Inductiveload):

[mediawiki/extensions/ProofreadPage@wmf/1.38.0-wmf.9] OSD: Add a ready hook for scripts

https://gerrit.wikimedia.org/r/740778

gerritbot added a project: Patch-For-Review.Nov 23 2021, 8:44 AM

Change 740778 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@wmf/1.38.0-wmf.9] OSD: Add a ready hook for scripts

https://gerrit.wikimedia.org/r/740778

Mentioned in SAL (#wikimedia-operations) [2021-11-23T12:26:27Z] <lucaswerkmeister-wmde@deploy1002> Synchronized php-1.38.0-wmf.9/extensions/ProofreadPage/modules/page/ext.proofreadpage.page.edit.js: Backport: [[gerrit:740778|OSD: Add a ready hook for scripts (T180569)]] (duration: 00m 56s)

This is now deployed: you can use it like this:

	mw.hook( 'ext.proofreadpage.osd-viewer-ready' ).add( function ( viewer ) {
	 	console.log( 'OSD viewer ready: ', viewer );
	} );

Inductiveload removed a project: Patch-For-Review.Nov 23 2021, 12:30 PM

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.9; 2021-11-16); removed MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Nov 23 2021, 1:00 PM

Fire mw.hook() event as soon as edit page rearrangement has been completedClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Fire mw.hook() event as soon as edit page rearrangement has been completed
Closed, ResolvedPublic
Actions