Fix TeXcount handling for newcolumntype#1487
Open
puneetdixit200 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a CLSI-generated TeXcount option file for word count requests so TeXcount handles
\newcolumntypedeclarations in the preamble without parsing their column definitions as real math/groups.The generated option file is written into the compile directory as
.overleaf-texcount-optionsand passed totexcountwith-opt=$COMPILE_DIR/.overleaf-texcount-options.Related issues / Pull Requests
Contributes to #1396
Verification
\newcolumntype{C}{>{$}c<{$}}document reported 8 TeXcount errors and 0 text words before the rule; with%preambleinclude \newcolumntype [ignore,xxx], it reported 1 text word and no errors.yarn --cwd services/clsi test:unit --run test/unit/js/CompileManager.test.jsyarn --cwd services/clsi test:unit --run test/unit/js/CompileManager.test.js test/unit/js/CompileController.test.jsgit diff --checkNotes:
yarn --cwd services/clsi lintcould not run in this checkout becauseeslintis not exposed on the workspace script path, and direct root ESLint invocation could not find a flat config forservices/clsi. The full CLSI unit suite also has unrelated local failures for missingservices/clsi/app/js/DockerRunnerand an absolute/overleaffixture path.Contributor Agreement