Skip to content
This repository was archived by the owner on Feb 13, 2024. It is now read-only.

Fix compilation on openSUSE#1998

Open
leviathanch wants to merge 2 commits into
anbox:masterfrom
leviathanch:master
Open

Fix compilation on openSUSE#1998
leviathanch wants to merge 2 commits into
anbox:masterfrom
leviathanch:master

Conversation

@leviathanch

Copy link
Copy Markdown

Hi
On openSUSE those small changes are needed for successfully building an RPM.
Please consider pulling this patch.
Thanks!

@morphis

morphis commented Feb 13, 2022

Copy link
Copy Markdown
Member

@leviathanch Looks like your branch contains other camera related changes too. I guess your intention was not to include them in this PR, right?

@leviathanch

leviathanch commented Feb 13, 2022 via email

Copy link
Copy Markdown
Author

@Fuseteam

Copy link
Copy Markdown

@leviathanch so those camera commits aren't intented for this PR?

@leviathanch

leviathanch commented Feb 14, 2022 via email

Copy link
Copy Markdown
Author

@Fuseteam

Copy link
Copy Markdown

the camera commits ended up as a part of this PR, you may want to remove them

@leviathanch

Copy link
Copy Markdown
Author

Oops...

@leviathanch

Copy link
Copy Markdown
Author

Fixed it

@Fuseteam

Copy link
Copy Markdown

Is this commit also intended to be part of this PR 000df0d @leviathanch?

@leviathanch

Copy link
Copy Markdown
Author

Yeah. Because otherwise Anbox doesn't work with the current LXC version openSUSE

@Fuseteam

Copy link
Copy Markdown

That sounds more like this PR depends on #1827.
hmmm at this point it's up to @morphis how he wants to handle it

@morphis morphis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants