implement bellman ford algorithm to find shortest path with negative weights#155
Open
jhsinger-klotho wants to merge 5 commits into
Open
implement bellman ford algorithm to find shortest path with negative weights#155jhsinger-klotho wants to merge 5 commits into
jhsinger-klotho wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
attempting to resolve #145
Implementing bellman ford algorithm for shortest path to include calculations of negative weights in a weighted graph.
The bellman ford algorithm will be run in ShortestPath when we have detected the algorithm is being run on a directed graph.
Algorithm will return an ErrTargetNotReachable if there is no path.
Because ShortestPath is a single source + target, performance lends itself to bellman ford (O(|V||E|)) in this scenario, so decided to implement that rather than johnsons algorithm (O(|V||E|+|V|^2log(|V|))).
Added unit tests to the bellman ford specific method and a single addition to shortestPath to test when the graph is directed