Add WithSkipEmptySourceMaps parser option#680
Open
dsmith3197 wants to merge 1 commit into
Open
Conversation
Owner
|
I think the behaviour should be to simply ignore missing or invalid source maps. This will match nodejs and browsers. |
Author
Are you suggesting that we remove the option altogether and always ignore empty/invalid source maps? Or are you saying that when the option is enabled, we should ignore all errors when parsing the source map? |
Owner
|
The former. Both nodejs and the browsers seem to behave this way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TypeScript compiler produces empty source map files for source files containing only type definitions.
This PR adds a
WithSkipEmptySourceMapsparser option that ignores the empty source map error produced here.