Skip to content

Added systemd service installation to Makefile#125

Closed
DevKisho wants to merge 1 commit into
javalsai:masterfrom
DevKisho:master
Closed

Added systemd service installation to Makefile#125
DevKisho wants to merge 1 commit into
javalsai:masterfrom
DevKisho:master

Conversation

@DevKisho

@DevKisho DevKisho commented Mar 16, 2026

Copy link
Copy Markdown

Now systemd can detect the service, since previously the lidm.service wasn't on the systemd's services file

idk why it wasn't here before, cus without it you cant enable the service since it's isn't there in the first place
@javalsai

Copy link
Copy Markdown
Owner

The default install recipe is meant to not be init system dependent. There's separate install scripts to install for each init system (install-service-systemd, install-service-<insertinithere>, etc) and also one that tries to detect the init system in use (install-service).

Those recipes are not in the Makefile itself but on the included services.mk, to separate the build and several init systems logic.

Closing as I don't intend for the default install script to do anything related to init systems atm.

@javalsai javalsai closed this Mar 16, 2026
@grialion

Copy link
Copy Markdown
Collaborator

Maybe a comment should be added there to avoid confusion. Not many people do recognize .mk files...

@javalsai

Copy link
Copy Markdown
Owner

Maybe a comment should be added there to avoid confusion. Not many people do recognize .mk files...

I don't think this is about not realizing services.mk is part of the makefile but trying to add services installation to the install recipe without knowing it's not intended to do so. Instead I could add a comment on the install recipe warning of this.

I think how it should behave is clear enough in the installation guide so I don't think it's needed, but if I find people tend to jump to this without reading the install guide first I will add one, I just think this is a one-time oversight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants