fix: prevent SQL injection in DatabaseDrop (Issue #12)#24
Open
bully-goose wants to merge 5 commits into
Open
Conversation
- Add Validators module with valid_identifier? and sanitize_identifier - Protect against SQL injection via identifier validation - Enforce PostgreSQL naming constraints (63 char max, alphanumeric+underscore) - Add comprehensive test coverage for edge cases
- Move InvalidIdentifierError and InvalidFilePathError into Pgchief::Errors - Update Validators module to raise Errors::InvalidIdentifierError and Errors::InvalidFilePathError - Update spec to reference new namespace
- Add identifier validation using Pgchief::Validators.sanitize_identifier - Use parameterized query (exec_params) for database existence check - Add security tests for SQL injection attempts
f775844 to
1692809
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements SQL injection protection for DatabaseDrop command as per Week 1 security plan.
Depends on #22 (validators module).